Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • L llvm-project
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 41
    • Issues 41
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 20
    • Merge requests 20
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Morello
  • llvm-project
  • Merge requests
  • !211

[WIP][Morello] Use indirect personality encoding for purecap

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Alex Richardson requested to merge fix-static-personality-encoding into morello/dev Oct 26, 2022
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 3

Without this change statically linked binaries will almost certainly have unparsable .eh_frame contents since the DW_EH_PE_absptr values used here will not be capability aligned, so libunwind will trigger an alignment fault calling getEncodedP(p, cieContentEnd, cieInfo->personalityEncoding).

For some reason I only saw this crash (while hanlding a C++ exception) in binaries built with LTO, not normal ones, but that's probably just caused by getting lucky on the alignment.

TODO: this needs a test case before merging

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-static-personality-encoding