GitLab

When LIBSHIM_ZERO_DDC is enabled and targeting pure capability ABI,
do_raw_args_marshalling() saves the original value of DDC and then
clears it. This is meant to prevent deriving tagged capabilities
from that point onwards using the original DDC value outside
libshim.

This change also removes 'rootcap' usages from libshim.

Built and tested on FVP.

Change-Id: I4cae99095f96999f5052ba83e43469168f7495cb

Add missing ramdisk_available properties to support full
Android R build.

Change-Id: Iba0a07e465d60d443c0fb2fda450145d4e16a6c9

Static libc should contain all the symbols necessary to run
an application. Dynamic libc, however, should only contain
symbols which are not "duplicated" in the dynamic linker.

So far both the dynamic linker and the shared libc had all
the libshim symbols. This proved to be working correctly,
however, having a fully singleton libshim is desirable.

From now on only symbols which are mandatory for libc are
provided, all the other libshim-internal symbols are weak.
Because the dynamic linker has the strong alternatives of
these symbols, linker will resolve these weak symbols so
that they come from the linker. This allows implementation
of a singleton pattern for libshim.

Built and tested on FVP.

Change-Id: I071ca7e23488293425990ead2c9261497c96786c

Change-Id: Ic25018dc121d21cb9906ad65e62d7cc2609bb432

Change-Id: I8487acb86f4f9258dc0668dc98de9713d0ee7a58

To ease debugging, this change adds support to make a difference
between system calls that are called best-effort and calls which
actually failed when the related message gets printed.

Change-Id: I05fd769ed2fcc391e8ce2ce823b0bcdf86a21e9e

Change-Id: I25d4918630abab5ef3058b8d90788767fc8fd86a

They allocate memory with a page granule. Yet they used to set the bounds
to the requested value instead. Some algorithms (like musl's malloc) make
use of the end of the page. This patch aligns the return bounds to the
closest fitting page size.

Change-Id: I53e934a6e165e5f85687aff6339e3dc5923e3e81

Change-Id: If19941a9c05bd2a3837929d384aa1d6bb4534a3e

Change-Id: I9906a0034ae3ae40fbc3fac0614445bbaa0888d5

This change removes pollution of many translation units with
contents of "asm/unistd.h". From now on it is only included in
the generated "libshim-syscalls.S" file. Moreover, this file is
only generated when targeting Bionic/Arm64.

Built and tested on the FVP.

Change-Id: Id8079d1c1817500edcf38d8d5f8c9b95526d6984

This change tries to generalize how the include paths of kernel headers
are added to the build. It does this by looking at the host and target
architectures, and the OS.

Note that compilation is only supported on either aarch64 or x86_64 hosts.
Co-authored-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Co-authored-by: Yury Khrustalev <yury.khrustalev@arm.com>

Change-Id: I25aa3a6c27ac502455d6c83338fe60f621b1129f

libshim needs to be available to all enabled variants of Bionic.

Change-Id: I7711bde27431fb969030b1a85d6a10b384be6a19

This property is removed.

Change-Id: I47244384b7f45a949dfa6534f904a6972ed8ac9c

Change-Id: I99684812c0cb1e10bc4abedf75db7a02147e7c48

Change-Id: Id54d723513c0a042c91c8574edc16e20b365bfd3

The syscalls are loaded based on the libc version (bionic_Q/bionic_R)
Also rename the syscall files:
bionic_arm64_Q.json -> bionic_Q_arm64.json
bionic_arm64_R.json -> bionic_R_arm64.json
bionic_morello_Q.json -> bionic_Q_morello.json
bionic_morello_R.json -> bionic_R_morello.json

Change-Id: Ib6f0915746b3a400693fbbdf37b3b92783cf7df1

Changes to the Android.bp and syscalls declarations are needed for
Android R. This approach avoids creating a separate branch for
Android R. Android.bp is now a symlink set up in the manifest.
The suitable bionic_arm64.json is chosen through the Android.bp.
The changes to Android_R.bp and bionic_arm64_R.json are added
in subsequent patches.

Change-Id: I3e3b4a1080676ae7f0ef2d405d50e12bee58d0c0

It is now possible to turn-off pretty-printing. This may be
useful when porting libc. If pretty-printing is turned-off
only the format strings will be printed.

Change-Id: I6f55e68187fd25ebc6818214d5c66a541ee63fb4

The json files for arm64 (Hybrid-cap ABI) and morello (Pure-cap ABI)
are effectively same.

Change-Id: Iffdba5c0b22115a4a6ec56631fc6e311d6894348

It is not a hard requirement to have clang-format installed.

Change-Id: Ifdbeb345294ad94e08df3ba1c44b3951ec3185de

There are some new rules regarding how mmap() should be handled:

1. If MAP_FIXED is set
  1.1 and hint is a tagged capability, then bounds must be properly set.
  1.2 and hint is an untagged capability, then MAP_FIXED should be
      replaced with MAP_FIXED_NOREPLACE.

2. If MAP_FIXED is not set then capability metadata should be ignored.

The change tries to support kernels which don't recognize
MAP_FIXED_NOREPLACE. Should the returned pointer be different from the
expected one, the code will try to unmap the newly allocated region
and will return -1 (EEXIST).

Built and tested on the FVP.

Change-Id: I28cbe334b940fd15baf61acadb6faaa868a1a017

This patch adds support for finding kernel headers on Debian based systems

Change-Id: Id004b1fb6042fb6d296f728ff1bbc18663e30607

This new trait helps decide if a type is safe to construct
from cleared memory.

Change-Id: Ia2de9e8fa0ee8dbcab645b00fd8e6601dccd2a3b

This patch adds further support to similar cases, if need be.

Change-Id: I64ada12495e214e8c784cc2dd2b495014d6c6aa0

Change-Id: I2e675d1df707b73eb487fbcc49eeca616223f7d9

Previously morello-specific sources weren't being
compiled because the substitution reference intended to
add their respective objects was incorrect.

Change-Id: I733379647adeb50789d44917a9995c2268cb7fa2

For details, please see the comments in rt_sigaction.cpp.

Change-Id: Ide976adac5ad62e36e5b9ab5bdf227b1698653b7

Unlike glibc and bionic, musl doesn't have its own
"linux" kernel headers, so we include this subsystem instead from
/usr/include, alongside its dependencies, asm and asm-generic.
We don't want to include anything else from the standard system
libraries to avoid potentially including unexpected C library code
into libshim and therefore into musl.
These files are symlinked into a local directory in the specified
build folder. All of these changes are conditional on LIBC equaling
musl.

Change-Id: I809caa8cb8b3f6352a247751a8d309b0c6fe33d7

LIBC is also now derived from LIBC_PATH.

Change-Id: I7fa73134b6441620d15dab3a6c682b72cee9fa1b

Change-Id: I7331d6bda9ff9306458c8a887cf9a9991f578676

Co-authored-by: Szabolcs Nagy <szabolcs.nagy@arm.com>

Change-Id: I6178e2ff8676b808f5c6900681e3451bae25cb54

Change-Id: I3760411c31fbe1549a783418de2efe5919a4f174

This is a non-functional change.

Change-Id: I2c7d288ee3374d9974da17099291ce29f9552883

In some libc implementations, such as musl, it is not rare that
some symbols are aliasing others.

This is most often done like this:

\#define getdents64 getdents

This behaviour could be circumvented by undefining macros, such as
_GNU_SOURCE, but then we would have to define all the types we check
or translate.

This changes solves this in a way so that the generated 'shims.cpp'
will look like this:

...
// int getdents64 (unsigned int, struct dirent*, unsigned int)
// ...
\#undef getdents64
LIBSHIM_FN(getdents64) {
...

These "undef"-s only affect the current translation unit and should
not cause any side-effects.

Built and tested with FVP.

Change-Id: Ic8e989918bc64869f0dd23131cc5760bc30a3cb9

This change adds json files for
  - glibc @ arm64
  - glibc @ x86_64
  - musl @ arm64
  - musl @ x86_64

Change-Id: Ic423c1feb303e0649f80428a1ca31de5ab774da6

Because of differences in sizeof(sigset_t), we can't rely on
libc's "view" of sigset_t. Libshim has to define the type the
kernel ABI expects.
Co-authored-by: Szabolcs Nagy <szabolcs.nagy@arm.com>

Change-Id: I0b6409c1ca43e75210e0a368f6dac6a5d3c41968

This change moves SigActionHandlerRegistry from local static to
global static scope. This way this registry is placed into .bss
and so there is no need for C++ runtime, such as __cxa_guard*.

Built and tested with FVP.

Change-Id: I2989bf6cce03c13c07f927d92b7e98f5fd5f66de

Syscalls implemented in assembly are not needed for other libcs.

Built and tested with FVP.

Change-Id: I7fec7ad03a88b51e65e77bf98a398e02c9a26a1a

Without the scope resolution operator (SRO), mmap64 would not be
found in case of musl libc. Be explicit that we want to call the
libc's implementation, which is in the global scope,  so that
compiler doesn't complain about mismatched parameter count.

Without SRO, morello::shim::mmap() would be the candidate in case of
musl. For bionic this works fine because it has a generated system
call with the same name.

Note that recursion into libshim is not possible in case of
mmap and munmap libc calls.

Built and tested with FVP.

Change-Id: Ia4332e442a21186548aa751a8126605c2d1cc5b8